Remove all remnants of --local #854
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #854 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 59 56 -3
Lines 3389 3173 -216
Branches 663 626 -37
==========================================
- Hits 3389 3173 -216 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MichaelGoberling
approved these changes
Mar 7, 2025
| mockRunDev.mockImplementation((config, dataDir, options, logFunc) => { | ||
| logFunc('boo') | ||
| expect(options.isLocal).toBe(undefined) | ||
| // expect(options.isLocal).toBe(undefined) |
shazron
approved these changes
Mar 12, 2025
Member
shazron
left a comment
shazron
left a comment
There was a problem hiding this comment.
Deleting code feels so good 🎶
This was referenced Mar 12, 2025
Closed
Member
|
Need this major version update change also: adobe/generator-app-common-lib#77 but it has complications (see PR description) |
10 tasks
purplecabbage
added a commit
that referenced
this pull request
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #813
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: